[docs] Migrate batch of demos to hooks/typescript #16334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 0bee9a7...e0810a6 |
|
Might take some time to get to this one. |
merceyz
force-pushed
the
docs/typescript
branch
2 times, most recently
from
84249bd
to
db5c04a
Compare
|
This is a lot of migration for one pull request +1,322 −111:eyes: |
oliviertassinari
approved these changes
Jun 23, 2019
eps1lon
reviewed
Jun 24, 2019
Closed
|
Should this pull request close #15451? |
The scope of that issue is a bit different. It is concerned with typing the possible values as literals instead of strings. Right now they still accept I'm going to experiment a bit with a possible type helper. |
|
@merceyz Awesome work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated the rest of the demos to hooks/typescript, there are a few missing but they require changes to the declarations i.e. #16333 or include too much change for this PR. It's big enough already.
Javascript and TypeScript are identical
Javascript and TypeScript are identical, changed to immediate export