Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support color="error" to every component #17475

Closed
wants to merge 22 commits into from
Closed

Added support color="error" to every component #17475

wants to merge 22 commits into from

Conversation

vadimka123
Copy link
Contributor

No description provided.

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 18, 2019

@material-ui/core: parsed: +1.24% , gzip: +0.49%

Details of bundle changes.

Comparing: 788bd98...0d2d2d6

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +1.24% 🔺 +0.49% 🔺 331,960 336,068 90,636 91,081
@material-ui/core/Paper 0.00% 0.00% 68,660 68,660 20,458 20,458
@material-ui/core/Paper.esm -0.00% -0.01% 62,098 62,097 19,203 19,202
@material-ui/core/Popper 0.00% +0.02% 🔺 28,397 28,397 10,159 10,161
@material-ui/core/Textarea 0.00% +0.09% 🔺 5,082 5,082 2,132 2,134
@material-ui/core/TrapFocus 0.00% +0.44% 🔺 3,766 3,766 1,596 1,603
@material-ui/core/styles/createMuiTheme -0.01% -0.03% 16,348 16,347 5,818 5,816
@material-ui/core/useMediaQuery 0.00% 0.00% 2,488 2,488 1,050 1,050
@material-ui/lab +0.16% 🔺 +0.06% 🔺 154,783 155,034 46,921 46,947
@material-ui/styles 0.00% 0.00% 51,420 51,420 15,288 15,288
@material-ui/system +0.06% 🔺 -0.16% 15,581 15,591 4,351 4,344
Button +1.06% 🔺 +0.32% 🔺 78,633 79,467 24,021 24,099
Modal 0.00% 0.00% 14,542 14,542 5,114 5,114
Portal 0.00% +0.23% 🔺 2,907 2,907 1,318 1,321
Rating -0.00% -0.01% 69,963 69,962 21,856 21,854
Slider +0.34% 🔺 +0.11% 🔺 75,084 75,337 23,184 23,209
colorManipulator -0.05% -0.07% 3,835 3,833 1,519 1,518
docs.landing 0.00% 0.00% 52,232 52,232 13,768 13,768
docs.main +0.19% 🔺 +0.08% 🔺 597,951 599,062 190,941 191,093
packages/material-ui/build/umd/material-ui.production.min.js +1.28% 🔺 +0.59% 🔺 302,847 306,732 87,081 87,594

Generated by 🚫 dangerJS against 0d2d2d6

@oliviertassinari
Copy link
Member

@vadimka123 Thank you for working on it! However, I think that we should avoid this approach, a dynamic based approach should be prefered, as proposed in #13875.

@oliviertassinari
Copy link
Member

@vadimka123 Thanks for taking the time to work it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants