[docs] Add classNames TS demo #17771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 4aea24a...17d2b23 |
|
Sorry but I don't understand why test_types is failing, can someone help me? |
eps1lon
changed the title
eps1lon
previously requested changes
Oct 7, 2019
Closed
The javascript version is generated automatically using |
merceyz
reviewed
Oct 7, 2019
| ); | ||
| } | ||
|
|
||
| export default withStyles(styles)(ClassNames); |
There was a problem hiding this comment.
Prefer using makeStyles over withStyles
oliviertassinari
approved these changes
Oct 7, 2019
|
@oliviertassinari Doesn’t the withStyles -> makeStyles need to happen first? |
|
@joshwooding I don't think it's important if we move forward with #16947. I'm happy to see the TypeScript migration. |
|
@lksilva Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.