Allow to pass mixins as a function to createMuiTheme() #18389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koistya
force-pushed
the
feat/styles/create-mixins
branch
from
9400f92
to
24263d3
Compare
Details of bundle changes.Comparing: 64ae0c6...c4e6b7e
|
koistya
force-pushed
the
feat/styles/create-mixins
branch
from
24263d3
to
c4e6b7e
Compare
|
@koistya Could you expand on the use-case? |
|
I don't think that we should move forward, as is. in #18219, we introduce the support of multi arguments for the const theme = createMuiTheme({}, theme => ({ mixins: { foo: 'bar' } }));The alternative is to apply the same pattern as |
const theme = createMuiTheme({}, theme => ({ mixins: { foo: 'bar' } }));Yeah, that would even be better. Good to know. |
|
@koistya It's not supported, it's an idea. |
|
What's wrong with the two stages approaches? const theme = createMuiTheme();
theme.mixins.element = {
padding: theme.spacing(1),
[theme.breakpoints.up('sm')]: {
padding: theme.spacing(2),
},
}; |
|
@oliviertassinari two stage approach does work for me. Will switch to |
|
@mbrookes Any preference for the next step? |
|
Two-stage seems good enough to me, now that I've grasped the use-case, but your call. |
|
Ok, it can wait then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage Example