Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Collapse] Add hidden class key to Collapse typings #19044

Merged
merged 1 commit into from
Dec 30, 2019
Merged

[Collapse] Add hidden class key to Collapse typings #19044

merged 1 commit into from
Dec 30, 2019

Conversation

pvdstel
Copy link
Contributor

@pvdstel pvdstel commented Dec 30, 2019

While attempting to override classes for the Collapse component, TypeScript did not accept the hidden field, although it is documented. This change adds it.

@mui-pr-bot
Copy link

No bundle size changes comparing 0c7ca74...a0b82fc

Generated by 🚫 dangerJS against a0b82fc

@oliviertassinari oliviertassinari added the component: Collapse The React component label Dec 30, 2019
@oliviertassinari oliviertassinari merged commit fb0ab9d into mui:master Dec 30, 2019
@oliviertassinari
Copy link
Member

@pvdstel thanks

@pvdstel pvdstel deleted the hidden-collapse-key branch December 30, 2019 13:38
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: Collapse The React component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvdstel @mui-pr-bot @oliviertassinari