[Typography] Add ability to specify custom variants #20203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested changes
Mar 21, 2020
There was a problem hiding this comment.
@lesha1201 Thanks for your interest in this effort, however, this should require a global change in the infrastructure, not a one-off case.
Details of bundle changes.Comparing: f008465...4b734a0 Details of page changes
|
| @@ -28,6 +28,7 @@ export default function createTypography(palette, typography) { | |||
| // Apply the CSS properties to all the variants. | |||
| allVariants, | |||
| pxToRem: pxToRem2, | |||
| customVariants = {}, | |||
There was a problem hiding this comment.
Spreading should already achieve the same.
Suggested change
| customVariants = {}, |
| @@ -15,7 +15,8 @@ export type Variant = | |||
| | 'body2' | |||
| | 'caption' | |||
| | 'button' | |||
| | 'overline'; | |||
| | 'overline' | |||
| | keyof CustomVariants; | |||
There was a problem hiding this comment.
We will prefer module augmentation.
Suggested change
| | keyof CustomVariants; |
| 'srOnly', | ||
| 'inherit', | ||
| ]), | ||
| variant: PropTypes.string, |
There was a problem hiding this comment.
To keep enough information in the generated API documentation.
Suggested change
| variant: PropTypes.string, | |
| variant: variant: PropTypes.oneOf(PropTypes.string, PropTypes.oneOf([…])), |
| @@ -5,6 +5,8 @@ import withStyles from '../styles/withStyles'; | |||
| import capitalize from '../utils/capitalize'; | |||
|
|
|||
| export const styles = theme => ({ | |||
| /* Styles applied to the root element if `variant` is from user defined variants (customVariants). */ | |||
| ...theme.typography.customVariants, | |||
There was a problem hiding this comment.
Suggested change
| ...theme.typography.customVariants, |
oliviertassinari
added
the
PR: needs revision
|
What is the issue that caused this to be closed -- Is there any remaining task, that will allow it to be merged? |
|
Any update on merging this functionality? |
|
Would really love to have this feature.. |
|
Implemented in #22006 which is only available in v5. Documentation can be found in https://next--material-ui.netlify.app/customization/components/#adding-new-component-variants. |
|
Also see #22257 for the future solution that will bypass the need to define custom styles. |
I appreciate the link but lets not confuse users even more. The issue is still open and we can't know if this will make it into any release. |
|
Right, agree: #22257 (comment) should clear the confusion. We have a workaround in v5-alpha.8 and will have a solution for this before v5 beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #15573
Description
It adds ability to specify custom variants for
<Typography />via theming. I'm not sure about such an implementation so feel free to close PR. It can be like a temporary solution before v5.Example: