Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add explicit dependency on @types/yargs #22339

Merged
merged 1 commit into from
Aug 23, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Aug 23, 2020

We started depending on them in #22055 but didn't add the dependency. Since yarn can't know about it the resulting node_modules in #22332 would pull in @types/yargs@13 in instead.

@mui-pr-bot
Copy link

No bundle size changes comparing df0205e...1ab6b80

Generated by 🚫 dangerJS against 1ab6b80

@eps1lon eps1lon merged commit 70daff2 into mui:next Aug 23, 2020
@eps1lon eps1lon deleted the core/fix-yargs-types branch August 23, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants