[docs] Fix unresolved returntypes for props #22459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
docs/stricter-types
branch
from
4c898d0
to
0015920
Compare
|
No bundle size changes comparing 2574143...2231138 |
github-actions
bot
added
the
PR: out-of-date
eps1lon
force-pushed
the
docs/stricter-types
branch
from
0015920
to
c72cb12
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and throw if it can't be resolved i.e. is
undefined.Only affected signature of
filterOptionsin https://next--material-ui.netlify.app/api/autocomplete/#props where we could identify the following fix:The issue became more apparent thanks to #22055. So TypeScript can help find bugs in rare circumstances.
Stacked on top of #22447 which is not required but to prevent dealing with merge conflicts I based it off of existing work. View diff to #22447.