[core] Fix failing CI on HEAD #23947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Dec 10, 2020
oliviertassinari
commented
mnajdova
approved these changes
Dec 10, 2020
|
Not sure, maybe #23745 wasn't rebased on |
Our CI only runs on the original branch and never on the potential merge commit. So if it's behind it's target branch the CI run isn't fully reliable. We occasionally have these integration issues but it's so rare that it isn't really worth it to run CI twice as often. No worries though. As long as CI is failing before we publish nothing happens. It would only be problematic if we deploy before CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.