Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Create issue labeled #24283

Merged
merged 1 commit into from
Jan 6, 2021
Merged

[core] Create issue labeled #24283

merged 1 commit into from
Jan 6, 2021

Conversation

xrkffgg
Copy link
Contributor

@xrkffgg xrkffgg commented Jan 6, 2021

HI, @oliviertassinari

Last time, when you type Duplicate of #xx, it will add the duplicate label automatically.

And I found that you often need to manually remove these 2 labels, so I added this. It will only remove these 2 labels if the issue has these 2 labels or one of them and has no effect on others. If there are any omissions labels, you can tell me.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 6, 2021

No bundle size changes

Generated by 🚫 dangerJS against 8dbfb02

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jan 6, 2021
@oliviertassinari oliviertassinari merged commit e4f2b26 into mui:next Jan 6, 2021
@oliviertassinari
Copy link
Member

@xrkffgg Nice automation :)

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 6, 2021

I'm not sure that it's working #24297

@xrkffgg
Copy link
Contributor Author

xrkffgg commented Jan 7, 2021

Let me check it

@xrkffgg xrkffgg deleted the patch-1 branch January 7, 2021 01:11
@xrkffgg
Copy link
Contributor Author

xrkffgg commented Jan 7, 2021

This is my mistake. I thought that GitHub Actions bot would trigger this condition, but it doesn't seem to be right now. The bot not trigger this.😅

Two ways:

  1. Use one actual token

A83565D3-CB80-4E52-B0DA-F7E16EDC35AD

  • For example, create a mui-issue-bot or just mui-bot
  1. If still use the default token, I will upgrade the program, which is also convenient.

@xrkffgg
Copy link
Contributor Author

xrkffgg commented Jan 7, 2021

I see you already have mui-pr-bot.
I think you can rename this to mui-bot and configure the token name as this user's token.

@xrkffgg
Copy link
Contributor Author

xrkffgg commented Jan 7, 2021

At the same time, I will also upgrade my program so that this mark-duplicate supports removing labels at the same time.
At first, I just thought about adding labels but missed removed.

@oliviertassinari Which solution do you choose?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 7, 2021

At the same time, I will also upgrade my program so that this mark-duplicate supports removing labels at the same time.
At first, I just thought about adding labels but missed removed.

@xrkffgg This sounds like a great option, keeping related things at the same place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants