[Menu] Deprecate old menu component #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
PR: Needs Review
docs
| @@ -33,8 +33,8 @@ export default { | |||
| List: require('./lists/list'), | |||
| ListDivider: require('./lists/list-divider'), | |||
| ListItem: require('./lists/list-item'), | |||
| Menu: require('./menu/menu'), | |||
| MenuItem: require('./menu/menu-item'), | |||
| Menu: require('./menus/menu'), | |||
There was a problem hiding this comment.
I think you shouldn't introduce this harsh breaking change just yet.
There was a problem hiding this comment.
I can't find better way to do it.
Unless we wait v0.15.0
There was a problem hiding this comment.
waiting that long will piss people off too! let's just add notes to Changelog about this breaking change and ways to use the old menu.
|
You can merge this when you are ready |
|
@subjectix @shaurya947 I have updated the CHANGELOG.md too. |
oliviertassinari
added a commit
that referenced
this pull request
Dec 10, 2015
[Menu] Deprecate old menu component
|
🎉 👍 |
This was referenced Dec 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove the usage of the old menu component from the source of the doc.
Fix #2395 and start adressing #2435.
P.S. I have noticed a lot of issue with the zIndex. I'm gonna work on this.