Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert] Migrate to emotion #24442

Merged
merged 15 commits into from
Jan 18, 2021
Merged

[Alert] Migrate to emotion #24442

merged 15 commits into from
Jan 18, 2021

Conversation

kutnickclose
Copy link
Contributor

I took a first stab at the Alert component for the emotion migration. One of #24405.

I have not yet figured out how to test and I would say generally a bit confused exactly how overridesResolver and useUtilityClasses works but I'll be figuring that out the next few days. I'm opening this now 1) in case anyone wants to add some pointers 😅 and 2) so no one duplicates the work.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 16, 2021 •
edited
Loading

@material-ui/lab: parsed: -0.11% 😍, gzip: +0.18%

Details of bundle changes

Generated by 🚫 dangerJS against 9eb18e5

@mnajdova mnajdova changed the title Migrate/component alert [Avatar] Migrate to emotion Jan 16, 2021
mnajdova
mnajdova reviewed Jan 16, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Great progress, left some comments on things that should be fixed or can be improved. Let me know if you have more questions and we can update the migration guide to include some more info :)

packages/material-ui/src/Alert/Alert.js Show resolved Hide resolved
packages/material-ui/src/Alert/Alert.js Outdated Show resolved Hide resolved
packages/material-ui/src/Alert/Alert.js Outdated Show resolved Hide resolved
packages/material-ui/src/Alert/Alert.js Outdated Show resolved Hide resolved
packages/material-ui/src/Alert/Alert.js Outdated Show resolved Hide resolved
packages/material-ui/src/Alert/alertClasses.js Show resolved Hide resolved
packages/material-ui/src/Alert/alertClasses.d.ts Show resolved Hide resolved
@povilass
Copy link
Contributor

@mnajdova Probably it's [Alert] Migration to emotion

@mnajdova mnajdova changed the title [Avatar] Migrate to emotion [Alert] Migrate to emotion Jan 16, 2021
@mnajdova
Copy link
Member

@mnajdova Probably it's [Alert] Migration to emotion

Right, thanks! The two PRs came approximately at the same time, so I must have confused them :)

@oliviertassinari oliviertassinari mentioned this pull request Jan 16, 2021
Closed
@oliviertassinari oliviertassinari added the component: alert This is the name of the generic UI component, not the React module! label Jan 16, 2021
mnajdova
mnajdova approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for spending the time 🙏

@mnajdova mnajdova merged commit 95b8edc into mui:next Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: alert This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kutnickclose @mui-pr-bot @povilass @mnajdova @oliviertassinari