Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accordion] Migrate to emotion #24518

Merged
merged 27 commits into from
Jan 22, 2021
Merged

[Accordion] Migrate to emotion #24518

merged 27 commits into from
Jan 22, 2021

Conversation

queengooborg
Copy link
Contributor

This PR migrates the Accordion component to emotion, as a part of #24405.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 20, 2021 •
edited
Loading

@material-ui/core: parsed: +0.14% , gzip: +0.10%

Details of bundle changes

Generated by 🚫 dangerJS against ccf936f

mnajdova
mnajdova reviewed Jan 20, 2021
View reviewed changes
packages/material-ui/src/Accordion/Accordion.js Outdated Show resolved Hide resolved
packages/material-ui/src/Accordion/Accordion.js Outdated Show resolved Hide resolved
packages/material-ui/src/Accordion/Accordion.js Outdated Show resolved Hide resolved
packages/material-ui/src/Accordion/Accordion.js Outdated Show resolved Hide resolved
packages/material-ui/src/Accordion/Accordion.js Outdated Show resolved Hide resolved
packages/material-ui/src/Accordion/Accordion.js Show resolved Hide resolved
packages/material-ui/src/Accordion/Accordion.js Outdated Show resolved Hide resolved
packages/material-ui/src/Accordion/Accordion.js Outdated Show resolved Hide resolved
packages/material-ui/src/Accordion/Accordion.js Outdated Show resolved Hide resolved
packages/material-ui/src/Accordion/Accordion.js Outdated Show resolved Hide resolved
@mnajdova mnajdova mentioned this pull request Jan 20, 2021
Closed
@github-actions github-actions bot mentioned this pull request Jan 20, 2021
Closed
@queengooborg

This comment has been minimized.

Sign in to view
@oliviertassinari oliviertassinari added the component: accordion This is the name of the generic UI component, not the React module! label Jan 20, 2021
@oliviertassinari
Copy link
Member

@vinyldarkscratch We do no longer need to look into .Naked. I have removed it. CI is green.

@queengooborg
Copy link
Contributor Author

Awesome, thanks @oliviertassinari!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 21, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 21, 2021
@mnajdova mnajdova merged commit ed94b01 into mui:next Jan 22, 2021
@queengooborg queengooborg deleted the migrate/Accordion branch January 22, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: accordion This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@queengooborg @mui-pr-bot @oliviertassinari @mnajdova