Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ToggleButton] Migrate to emotion #24674

Merged
merged 3 commits into from
Jan 28, 2021
Merged

[ToggleButton] Migrate to emotion #24674

merged 3 commits into from
Jan 28, 2021

Conversation

natac13
Copy link
Contributor

@natac13 natac13 commented Jan 28, 2021

#24405

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 28, 2021 •
edited
Loading

@material-ui/core: parsed: +0.15% , gzip: +0.11%
@material-ui/lab: parsed: +0.14% , gzip: +0.03%

Details of bundle changes

Generated by 🚫 dangerJS against e8dd02d

@oliviertassinari oliviertassinari added the component: toggle button This is the name of the generic UI component, not the React module! label Jan 28, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 28, 2021
Closed
mnajdova
mnajdova reviewed Jan 28, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run yarn proptypes & yarn docs:api

packages/material-ui/src/ToggleButton/ToggleButton.js Show resolved Hide resolved
packages/material-ui/src/ToggleButton/ToggleButton.js Outdated Show resolved Hide resolved
packages/material-ui/src/ToggleButton/ToggleButton.js Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Jan 28, 2021
Closed
mnajdova
mnajdova approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oliviertassinari oliviertassinari merged commit 5eefc9e into mui:next Jan 28, 2021
natac13 added a commit to natac13/material-ui that referenced this pull request Jan 30, 2021
@natac13
[ToggleButton] Migrate to emotion (mui#24674)
756fd71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: toggle button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natac13 @mui-pr-bot @mnajdova @oliviertassinari