-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Drawer] Migrate to emotion #25091
Merged
Merged
[Drawer] Migrate to emotion #25091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: drawer
This is the name of the generic UI component, not the React module!
label
Feb 25, 2021
@material-ui/core: parsed: +0.25% , gzip: +0.19% |
oliviertassinari
added
the
PR: needs revision
The pull request can't be merged. More details is available on the code review or fails in the CI
label
Feb 25, 2021
Run yarn lint to fix a test with prettier and contribution file says it. |
povilass
reviewed
Feb 26, 2021
povilass
reviewed
Feb 26, 2021
oliviertassinari
added
new feature
New feature or request
and removed
PR: needs revision
The pull request can't be merged. More details is available on the code review or fails in the CI
labels
Feb 28, 2021
oliviertassinari
force-pushed
the
drawer-to-emotion
branch
from
February 28, 2021 22:40
a5f9364
to
f2522bf
Compare
As far as my experience go for this test: it has been a pain for in half the time. Solving it was mostly about writting the tests correctly, so no value.
oliviertassinari
force-pushed
the
drawer-to-emotion
branch
from
February 28, 2021 22:42
f2522bf
to
bf9ac0b
Compare
oliviertassinari
approved these changes
Feb 28, 2021
Thanks! I went forward fixing the test cases rapidly. 31 pull requests, already 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: drawer
This is the name of the generic UI component, not the React module!
new feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24405
I have 4 test failing still....
First 2 I am not sure how they are related to
Drawer
The second 2 I will try and work out. I am a little rusty with these conversions lol.
However, the code has been changed so a good start I think.