Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Fix jss-server-side output with nextjs #25179

Closed
wants to merge 1 commit into from
Closed

[examples] Fix jss-server-side output with nextjs #25179

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 3, 2021

Fixes #25178

.add @babel/core as devDependencies for @emotion/styled.
2.add prefix and compressed jss-server-side output

1.add @babel/core as devDependencies for @emotion/styled.
2.add prefix and compressed jss-server-side output
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 3, 2021

No bundle size changes

Generated by 🚫 dangerJS against bdec698

@ghost
Copy link
Author

ghost commented Mar 3, 2021

it works perfect😋
image

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 3, 2021

I'm closing as v5 is already fixing this. This is specific to v4 for which we only focus on major issues. Thanks for the effort.

@ghost
Copy link
Author

ghost commented Mar 4, 2021

I'm closing as v5 is already fixing this. This is specific to v4 for which we only focus on major issues. Thanks for the effort.

Sorry about my poor english.

Sorry i'm still a bit confused.

first, i used v5 already, see #25178
and this pr is for the examples with nextjs (instead of @material-ui/core self)

i have view material-ui website source code branch-next now,it still handles the issue manually

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 4, 2021

i used v5 already

@codewangshuhao You have linked an example with the Radio component, which isn't yet migrated to the styled API in the most recently published package. It's done in #25152, unreleased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong jss-server-side output in examples with nextjs(include typescript)
2 participants