Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] Fix placement regression #25255

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 7, 2021

I have found this regression having a quick look at #25215.

To reproduce, you can:

Before
Screenshot 2021-03-07 at 19 19 58

After
Screenshot 2021-03-07 at 19 20 10 1

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module! labels Mar 7, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 7, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 6611bc3

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 8, 2021

I can't think of any easy way to test this. It's the CSS that is wrong, which should require a visual regression. We have two options:

  1. Only fix the regressions (as I did here)
  2. Figure out how to write a test, have it non-flaky, and resilient to future changes.

Considering that I could already do 1. in about 10 minutes and that the regression stayed unnoticed for only 10 days, I think that the most efficient direction is to move in (1.). At least, we have a reproduction in the PR's description.

@oliviertassinari oliviertassinari merged commit b725a3f into mui:next Mar 9, 2021
@oliviertassinari oliviertassinari deleted the tooltip-placement-regression branch March 9, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants