Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpeedDial] Reset tooltip state when the speed dial is closed #25259

Merged
merged 11 commits into from
Mar 12, 2021

Conversation

m4theushw
Copy link
Member

Fixes #25215.

This PR also fixes the tooltip placement when the direction prop is left or right.

Before:

Screenshot from 2021-03-07 22-25-05

After:

Screenshot from 2021-03-07 22-22-41

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 8, 2021

Details of bundle changes

Generated by 🚫 dangerJS against c689d64

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module! labels Mar 8, 2021
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work. But we need to investigate #25259 (comment) first. That analysis is incomplete.

@oliviertassinari oliviertassinari merged commit 5511e9c into mui:next Mar 12, 2021
@m4theushw m4theushw deleted the speedDial-tooltip branch November 1, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SpeedDial] Tooltip not closing when quickly moving the mouse away
4 participants