Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Add test validator to improve DX #25854

Merged
merged 6 commits into from
Apr 23, 2021
Merged

[test] Add test validator to improve DX #25854

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58edc1e
add validator
siriwatknp Apr 20, 2021
ad0b8b6
remove describe
siriwatknp Apr 20, 2021
6f28d34
move to test file
siriwatknp Apr 21, 2021
b06fa5b
simplify validation
siriwatknp Apr 22, 2021
620fe81
fix typo
siriwatknp Apr 22, 2021
db90b5e
run yarn prettier
siriwatknp Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 40 additions & 6 deletions test/utils/describeConformanceV5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ import {
testRootClass,
} from './describeConformance';

function throwMissingPropError(field) {
throw new Error(`missing "${field}" in options

> describeConformanceV5(element, () => options)
`);
}

/**
* Material-UI components have a `components` prop that allows rendering a different
* Components from @inheritComponent
Expand Down Expand Up @@ -41,6 +48,15 @@ function testThemeDefaultProps(element, getOptions) {
it("respect theme's defaultProps", () => {
const testProp = 'data-id';
const { muiName, render } = getOptions();

if (!muiName) {
throwMissingPropError('muiName')
}

if (!render) {
throwMissingPropError('render')
}

const theme = createMuiTheme({
components: {
[muiName]: {
Expand Down Expand Up @@ -76,6 +92,14 @@ function testThemeStyleOverrides(element, getOptions) {
return;
}

if (!muiName) {
throwMissingPropError('muiName')
}

if (!render) {
throwMissingPropError('render')
}

const testStyle = {
marginTop: '13px',
};
Expand Down Expand Up @@ -199,6 +223,14 @@ function testThemeVariants(element, getOptions) {
throw new Error('missing testVariantProps');
}

if (!muiName) {
throwMissingPropError('muiName')
}

if (!render) {
throwMissingPropError('render')
}

const testStyle = {
marginTop: '13px',
};
Expand Down Expand Up @@ -251,14 +283,16 @@ const fullSuite = {
export default function describeConformanceV5(minimalElement, getOptions) {
const { after: runAfterHook = () => {}, only = Object.keys(fullSuite), skip = [] } = getOptions();

const filteredTests = Object.keys(fullSuite).filter(
(testKey) => only.indexOf(testKey) !== -1 && skip.indexOf(testKey) === -1,
);

describe('Material-UI component API', () => {
after(runAfterHook);

Object.keys(fullSuite)
.filter((testKey) => only.indexOf(testKey) !== -1 && skip.indexOf(testKey) === -1)
.forEach((testKey) => {
const test = fullSuite[testKey];
test(minimalElement, getOptions);
});
filteredTests.forEach((testKey) => {
const test = fullSuite[testKey];
test(minimalElement, getOptions);
});
});
}