Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Switch] Added outlined variant #25920

Closed

Conversation

DanielBretzigheimer
Copy link
Contributor

@DanielBretzigheimer DanielBretzigheimer commented Apr 23, 2021

My try to implement the android 12 switch style.
Issue: #25919

This is my first pull request, so I'm appreciating feedback on it. 😅

I have created a new section in the switches documentation and tried orienting on the button/paper variants.

Preview: https://deploy-preview-25920--material-ui.netlify.app/components/switches/#variants

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 23, 2021

Details of bundle changes

@material-ui/core: parsed: +0.22% , gzip: +0.20%

Generated by 🚫 dangerJS against b620796

@DanielBretzigheimer
Copy link
Contributor Author

Some pictures how my implementation looks:
image
image

@DanielBretzigheimer DanielBretzigheimer force-pushed the updated-switch-style branch 2 times, most recently from a37b038 to 953600c Compare April 24, 2021 11:53
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 26, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 26, 2021
@oliviertassinari oliviertassinari added design: material This is about Material Design, please involve a visual or UX designer in the process component: switch This is the name of the generic UI component, not the React module! labels Apr 28, 2021
@mnajdova
Copy link
Member

Should we add just a customization demo at this moment as suggested in #25919?

@oliviertassinari
Copy link
Member

I'm closing for #26096. @DanielBretzigheimer thanks for bringing this topic. I'm creating a reminder for the end of the year, as it's about when Android 12 seems to be meant to be released.

@DanielBretzigheimer DanielBretzigheimer deleted the updated-switch-style branch March 18, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: switch This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants