Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Remove scheduler/tracing #26062

Merged
merged 2 commits into from
Apr 29, 2021
Merged

[test] Remove scheduler/tracing #26062

merged 2 commits into from
Apr 29, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 29, 2021

It's been removed in facebook/react#20037 so let's drop it as well. Compat testing with react@next is more important than tracing interactions. Edit: Too late for it to be pre-emptive. Already broke: https://app.circleci.com/pipelines/github/mui-org/material-ui/41292/workflows/23024986-c4d2-42ec-9eb6-852507c803b8/jobs/246993

We can re-implement it for most (if not all) updates with a stack based approach anyway. Mainly because the updates we track are all sync anyway. I'm not even sure we trace more than one interaction anyway.

test-profile of this PR: https://mui-dashboard.netlify.app/test-profile/247033

@eps1lon eps1lon added the test label Apr 29, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 29, 2021

No bundle size changes

Generated by 🚫 dangerJS against a4714fc

@eps1lon eps1lon marked this pull request as ready for review April 29, 2021 21:42
@eps1lon eps1lon merged commit f4ccd4f into mui:next Apr 29, 2021
@eps1lon eps1lon deleted the test/drop-tracing branch April 29, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants