Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReactNative] Bootstrap for a documentation app #2611

Merged
merged 1 commit into from
Dec 21, 2015
Merged

[ReactNative] Bootstrap for a documentation app #2611

merged 1 commit into from
Dec 21, 2015

Conversation

oliviertassinari
Copy link
Member

I think that we should follow https://github.com/benoitvallon/react-native-nw-react-calculator
to answer the following question: How do we split our code with the different platforms?
They are using a file extension patterns. For instance, for a Button component, we could have:

  • Button.jsx: browser endpoint, use react-dom
  • Button.android.jsx: android endpoint, that can use .native.jsx if it's not specific to android
  • Button.ios.jsx: iOS endpoint, that can use .native.jsx if it's not specific to iOS
  • Button.native.jsx shared implementation for react-native if we can

I'm also wondering, should we support iOS? IMHO that doesn't add any value.

I can't merge the new native/ folder with the docs/ until we upgrade to babel@6.
This is how it looks soo far:
capture d ecran 2015-12-21 a 01 16 49
capture d ecran 2015-12-21 a 01 12 27

@oliviertassinari oliviertassinari changed the title [WIP] React native boostrap [ReactNative] Bootstrap for a documentation app Dec 21, 2015
@oliviertassinari
Copy link
Member Author

@subjectix @newoga Any feedbacks on this?

@alitaheri
Copy link
Member

@oliviertassinari I've never worked with react-native. I can provide feedback with this. but I can say, I like what I'm looking at 😁 😁

@newoga
Copy link
Contributor

newoga commented Dec 21, 2015

Same here, I've been meaning to give react-native a try but have only read blog posts and documentation. Looks good to me too though. I'm onboard with the file extension patterns. 👍

Would supporting iOS be much more difficult? Just curious. 😄

I just found this link by the way, haven't read it in detail but looks like it could be relevant for iOS if we want to consider it down the road...
https://design.google.com/articles/design-from-ios-to-android/

@oliviertassinari
Copy link
Member Author

Would supporting iOS be much more difficult?

We will have to check that it's working properly. But technically, that's more or less the same.

@oliviertassinari
Copy link
Member Author

I'm merging this one.
However, I can't move forward until with support babel 6.

oliviertassinari added a commit that referenced this pull request Dec 21, 2015
[ReactNative] Bootstrap for a documentation app
@oliviertassinari oliviertassinari merged commit 19fb970 into mui:master Dec 21, 2015
@oliviertassinari oliviertassinari deleted the react-native-boostrap branch December 21, 2015 16:30
@zannager zannager added the docs Improvements or additions to the documentation label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants