-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Upgrade Algolia search UI #26397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what happened with your lockfile. Try reverting that change (but keep the change to the package.json) and then run yarn install
again. But make sure your run yarn install
from the workspace root not ./docs
Having a quick look at the preview URL, I can notice that:
Regarding the button that triggers the modal, we will likely need to rework the UI. I would propose we keep the previous style (both for the docs, and the website, so two different versions) |
@oliviertassinari styling is done but I think the search result is not good.
Light mode Dark mode
|
@siriwatknp Great, thanks for taking the lead on this one. This can be a great side project when you are waiting for feedback on one of the breaking changes. What I could find, so far:
If it's true, then we might need to have two accounts, one for v4, and one for v5.
Agree
What do you mean by "Hit path"? |
@siriwatknp Please review the changes, |
@arpitBhalla thanks for the udpate. I had a look at the changes 7 days ago. We are off from the target, so much so that, it felt like a WIP, I didn't take the time to comment as I felt most of the feedback of #26397 (comment) were not taken into account yet (I see 2/10 that might have been fixed). Note that these ten items are unlikely to be enough. I could already found a new obvious one, so I assume a deeper review will uncover improvement opportunities. I hope it helps. |
Preview: https://deploy-preview-26397--material-ui.netlify.app/
Closes #26112
Benchmark