-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Button] Use deeper imports from unstyled, correct docs #28074
Conversation
Could we wait for the package rename changes to go in before we merge this one? |
Sure, no problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, a small detail PR 🍭, but the CI is failing 😁
I think that it fails because of https://github.com/mui-org/material-ui/blob/bbc5561f360985430fc6ef4f81eca0ce093eaf98/packages/material-ui/scripts/rollup.config.js#L85 while we have a .ts file not a .js one. |
@oliviertassinari Is there some known workaround or should I try to fix the config? |
I guess we need to fix this line. We could test if the ts file is present, return it and default to the .js file if not. |
Fixing in #28094 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the follow up.
@oliviertassinari can I have approval, then? 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the approval :))
Thanks :) |
Small corrections discussed in #27600 (review)
Preview https://deploy-preview-28074--material-ui.netlify.app/components/buttons/#unstyled