[LeftNav] Add iOS momentum scroll

[ffxsam]

It really bugged me that there was no touch scroll (momentum) on a few Material UI elements. Makes the interface feel a bit dated.

[ffxsam]

I was able to add it to DropDownMenu, no problem. But I applied the SAME exact style to LeftNav, and well.. look at this weirdness:

The first one circled is LeftNav. The second one is an activated DropDownMenu. Notice how the LeftNav style is webkit-overflow-scrolling and the other is -webkit-overflow-scrolling, yet the code for both is _exactly the same_. What the heck?

[alitaheri]

I'm guessing this must be related to auto-prefixer. @oliviertassinari Thoughts?

[oliviertassinari]

What the heck?

I agree, I'm wondering if this has nothing to do with https://github.com/rofrischmann/inline-style-prefixer.

[ffxsam]

That's exactly it. I didn't know about this at before now. It should be WebkitOverflowScrolling, not webkitOverflowScrolling. Fixed, and tested on iPhone 5s, iPad Air, and iOS Simulator (iPad). Anyone else can feel free to double check before merging.

[oliviertassinari]

Could you add a comment like Add momentum scrolling for iOS?

[oliviertassinari]

@ffxsam That feel much better on iOS 👍!
Can you have a look at my comment and squash down the commit then so we can merge?

[ffxsam]

What about moving this style to the DropDownMenu component?

Where exactly? I tried putting in the root style but it had no effect. I'm still not familiar enough with the code structure to know the proper place to put things. I think I tried putting it in that component and it didn't work..

Also, you'll have to tell me how I should squash my commits, it's not something I do very often and I don't want to mess up the branch. :)

[oliviertassinari]

Where exactly?

Try here: https://github.com/callemall/material-ui/blob/master/src/DropDownMenu/DropDownMenu.jsx#L401.

[ffxsam]

Nope, that didn't work. I'll put it back. The overflow scrolling property has to be in a very specific spot.. I put it back to where it works.

[ffxsam]

I tried to squash/rebase.. I think I messed up. I might delete this PR and start over again.

[oliviertassinari]

Nope, that didn't work. I'll put it back.

My bad. Applying this style to the animation component sounds wrong to me.
What's your use case for it?

[ffxsam]

What do you mean by use case? It's the only place that WebkitOverflowScrolling seems to have worked. Is there another place you'd recommend putting it?

[oliviertassinari]

Is there another place you'd recommend putting it?

I have to investigate. But adding this style inside the animation component doesn't feel right. The /popover-animation-from-top.jsx component should only have on responsibility: take care of the animation.

[oliviertassinari]

@ffxsam Any update on this?
What do you think about submitting a PR for the LeftNav component? This part is good and can be merged IMHO 👍.
For the Popover we need to find a better approach.

[ffxsam]

Sorry, been totally swamped lately! Please keep this open.. I will return to it as soon as I can and merge the LeftNav. And then I'll take a second look at Popover.

[ffxsam]

Ok, I removed it from the Popover. I would normally squash the commits, but I know once you do that, you can't re-push.

[mbrookes]

I would normally squash the commits, but I know once you do that, you can't re-push.

git push -f

[ffxsam]

Ok. I thought that was bad practice. Should I squash and force push then?

[mbrookes]

Yes please.

[oliviertassinari]

@ffxsam Thanks! That's much better 👍: