[Core] Remove the deprecated API of v0.14.x #3108

oliviertassinari · 2016-01-30T21:18:23Z

This PR is in preparation for the next 0.15.0 release.

0.14.0 Deprecations

This is a list of deprecations that were added in version 0.14.0. I recommend that we remove these in our first 0.15.0 release candidate.

Deprecated components

menu/menu (including related components)
lists/list-divider (Remove list-divider export from lists/index.js)
menus/menu-divider
drop-down-icon (PR #2994) (There is still logic checking for DropDownIcon in toolbar-group.jsx)

Deprecated imperative methods

Dialog: _getAction()
~~DropDownMenu: getInputNode()~~ Needed by the TextField component.
LeftNav: toggle(), open(), close()
Snackbar: show(), dismiss()
TextField: setErrorText(), setValue()(Need to figure out what to do with clearValue())

Deprecated props

Dialog: actionFocus, width
DropDownMenu: displayMember, labelMember, menuItems, selectedIndex, valueLink, valueMember
SelectField: labelMember, menuItems, selectedIndex
IconMenu: closeOnItemTouchTap (not deprecated in docs)
LeftNav: header, menuItemClassName, menuItemClassNameLink, menuItemClassNameSubheader, menuItems, onChange, onNavClose, onNavOpen, selectedIndex
Snackbar: onDismiss, onShow, openOnMount

alitaheri · 2016-01-30T21:47:11Z

−1,919 !!! 😱 😱 😱

alitaheri · 2016-01-30T21:54:20Z

Looks good so far. I'll have a deeper look tomorrow. We should be careful with this one 😅 😅

oliviertassinari · 2016-01-31T11:01:17Z

@newoga Thanks for doing https://gist.github.com/newoga/1a604b642fd6a52e03a4. I have done a second commit to remove the missing deprecated API.

newoga · 2016-01-31T23:00:09Z

@newoga Thanks for doing https://gist.github.com/newoga/1a604b642fd6a52e03a4. I have done a second commit to remove the missing deprecated API.

No problem, I'm going to check this PR out now. Thanks for doing this! 😄

newoga · 2016-01-31T23:16:28Z

Additional notes:

Remove list-divider export from lists/index.js
Shouldn't break anything, but since we're getting rid of DropDownIcon, we could probably delete this logic in toolbar-group.jsx: https://github.com/callemall/material-ui/blob/master/src/toolbar/toolbar-group.jsx#L188-L194
Since we've removed the show and dismiss imperative methods and their related onX props from snackbar.js, we should consider doing the same or deprecating the same on the date and time pickers
I'll admit, there was so much removed in left-nav and I didn't look at it super closely, but since it's fairly simple now, we could probably just test and make sure advertised functionality works

newoga · 2016-01-31T23:34:37Z

src/TextField/TextField.jsx

-    }
-  },
-
-  setValue(newValue) {


This component's clearValue() method uses this function. We'll either have to remove that function too or implement it manually. Ideally we can just remove it but we never formally deprecated that function.

Good catch!

Ideally we can just remove it but we never formally deprecated that function.

It was deprecated, calling clearValue was throwing the warning of setValue.

True! That makes sense, be gone clearValue()!

newoga · 2016-02-01T00:43:44Z

@oliviertassinari Alright, I gave this a quick over. I think we're close. After we tidy up the remaining issues, I'll test all the affected components one more time and then we should be done. I'm excited for removing code and cleaning up! Certainly should make it easier on contributors.

oliviertassinari · 2016-02-01T10:04:48Z

src/DropDownMenu/DropDownMenu.jsx

+    const menuItemElements = React.Children.map(children, (child) => {
+      const clone = React.cloneElement(child, {
+        onTouchTap: this._onMenuItemTouchTap.bind(this, index, child.props.value),
+      }, child.props.children);


That seems absurd to pass the children parameter. I'm gonna remove it, we will save some CPU cycles: https://github.com/facebook/react/blob/v0.14.7/src/isomorphic/classic/element/ReactElement.js#L252.

oliviertassinari · 2016-02-01T10:13:35Z

Thanks for your feedback guys! I think that I have tackled all your points in my second commit.
It can be reviewed again.

newoga · 2016-02-01T18:36:50Z

src/left-nav.jsx

     * Callback function that is fired when the open state of the `LeftNav` is
     * requested to be changed. The provided open argument determines whether
     * the `LeftNav` is requested to be opened or closed. Also, the reason
     * argument states why the `LeftNav` got closed or opend. It can be either
-     * `'clickaway'` for menuItem and overlay clicks, `'escape'` for pressing the
+     * `'clickaway'` for overlay clicks, `'escape'` for pressing the
     * escape key and 'swipe' for swiping. For opening the reason is always `'swipe'`.


Nit: Not your fault, but just noticed 'swipe' on this line also doesn't have the 'swipe' back ticks. Maybe we can just get it fixed here.

This commit removes the import of `mergeStyles` and `prepareStyles` from `utils/styles` for most components and files. The use of `mergeStyles` has been replaced with `Object.assign` and the `prepareStyles` function that is imported has been replaced with the `prepareStyles` implementation stored in context. As of this commit, there are only two files importing from `utils/styles`: 1. `menus/menu-divider.jsx` (which is planned for removal in PR mui#3108) 2. `mixins/style-propable.js` (which many components are still using, but the removal of this mixin is tracked in mui#2852) Signed-off-by: Neil Gabbadon <[email protected]>

newoga · 2016-02-04T09:22:27Z

@alitaheri I haven't had another full look at this since the first time. I can review again when I wake up but I remember feeling good about this from before. If you review and feel like its ready, you and @oliviertassinari can merge without me 👍

alitaheri · 2016-02-04T10:14:43Z

Looking good @oliviertassinari. Thanks a lot 👍 👍 Feel free to merge this piece of art 😍 😍

oliviertassinari · 2016-02-04T11:33:47Z

Awesome, I will rebase and merge 🚀. Thanks again for your feedbacks.

[Core] Remove the deprecated API of v0.14.x

alitaheri · 2016-02-04T18:12:14Z

Awesome 👍 👍 🎈 🎉 🎈 😍

newoga · 2016-02-04T18:13:28Z

Awesome 👍 👍 🎈 🎉 🎈 😍

Agreed 👍 👍 I pulled this immediately. 😆

oliviertassinari · 2016-02-04T18:17:17Z

I pulled this immediately

Same here, all my tests are green 🎉.

This commit removes the import of `mergeStyles` and `prepareStyles` from `utils/styles` for most components and files. The use of `mergeStyles` has been replaced with `Object.assign` and the `prepareStyles` function that is imported has been replaced with the `prepareStyles` implementation stored in context. As of this commit, there are only two files importing from `utils/styles`: 1. `menus/menu-divider.jsx` (which is planned for removal in PR mui#3108) 2. `mixins/style-propable.js` (which many components are still using, but the removal of this mixin is tracked in mui#2852) Signed-off-by: Neil Gabbadon <[email protected]>

oliviertassinari added Core labels Jan 30, 2016

oliviertassinari mentioned this pull request Jan 30, 2016

[Docs] Change 'Material UI' to 'Material-UI' #3107

Merged

oliviertassinari changed the title ~~[Core] Remove the deprecated API~~ [Core] Remove the deprecated API (and as many dead code as I could find) Jan 30, 2016

oliviertassinari added this to the 0.15.0 Release milestone Jan 31, 2016

newoga reviewed Jan 31, 2016
View reviewed changes

oliviertassinari reviewed Feb 1, 2016
View reviewed changes

newoga reviewed Feb 1, 2016
View reviewed changes

oliviertassinari changed the title ~~[Core] Remove the deprecated API (and as many dead code as I could find)~~ [Core] Remove the deprecated API of v0.14.x Feb 3, 2016

newoga mentioned this pull request Feb 4, 2016

[Core] Remove dependency on utils/styles from components #3169

Merged

[Core] Remove the deprecated API of v0.14.x

501c16f

oliviertassinari added a commit that referenced this pull request Feb 4, 2016

Merge pull request #3108 from oliviertassinari/remove-deprecated-code

70b4e0f

[Core] Remove the deprecated API of v0.14.x

oliviertassinari merged commit 70b4e0f into mui:master Feb 4, 2016

oliviertassinari deleted the remove-deprecated-code branch February 4, 2016 16:06

yongxu mentioned this pull request Feb 5, 2016

[Core] remove style-propable mixin from components #2852

Closed

90 tasks

alitaheri removed the PR: Needs Review label Feb 15, 2016

mbrookes mentioned this pull request May 8, 2016

[Docs] Update the Roadmap #4205

Closed

zannager added the core Infrastructure work going on behind the scenes label Mar 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Core] Remove the deprecated API of v0.14.x #3108

[Core] Remove the deprecated API of v0.14.x #3108

oliviertassinari commented Jan 30, 2016

alitaheri commented Jan 30, 2016

alitaheri commented Jan 30, 2016

oliviertassinari commented Jan 31, 2016

newoga commented Jan 31, 2016

newoga commented Jan 31, 2016

newoga Jan 31, 2016

oliviertassinari Feb 1, 2016

newoga Feb 1, 2016

newoga commented Feb 1, 2016

oliviertassinari Feb 1, 2016

oliviertassinari commented Feb 1, 2016

newoga Feb 1, 2016

newoga commented Feb 4, 2016

alitaheri commented Feb 4, 2016

oliviertassinari commented Feb 4, 2016

alitaheri commented Feb 4, 2016

newoga commented Feb 4, 2016

oliviertassinari commented Feb 4, 2016

[Core] Remove the deprecated API of v0.14.x #3108

[Core] Remove the deprecated API of v0.14.x #3108

Conversation

oliviertassinari commented Jan 30, 2016

0.14.0 Deprecations

Deprecated components

Deprecated imperative methods

Deprecated props

alitaheri commented Jan 30, 2016

alitaheri commented Jan 30, 2016

oliviertassinari commented Jan 31, 2016

newoga commented Jan 31, 2016

newoga commented Jan 31, 2016

newoga Jan 31, 2016

Choose a reason for hiding this comment

oliviertassinari Feb 1, 2016

Choose a reason for hiding this comment

newoga Feb 1, 2016

Choose a reason for hiding this comment

newoga commented Feb 1, 2016

oliviertassinari Feb 1, 2016

Choose a reason for hiding this comment

oliviertassinari commented Feb 1, 2016

newoga Feb 1, 2016

Choose a reason for hiding this comment

newoga commented Feb 4, 2016

alitaheri commented Feb 4, 2016

oliviertassinari commented Feb 4, 2016

alitaheri commented Feb 4, 2016

newoga commented Feb 4, 2016

oliviertassinari commented Feb 4, 2016