Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppCanvas] Remove style-propable mixin #3184

Merged
merged 1 commit into from
Feb 5, 2016

Conversation

newoga
Copy link
Contributor

@newoga newoga commented Feb 5, 2016

Signed-off-by: Neil Gabbadon [email protected]

@oliviertassinari
Copy link
Member

@newoga That looks good 👍

@newoga
Copy link
Contributor Author

newoga commented Feb 5, 2016

Done, switched setState to use nextContext.muiTheme || this.state.muiTheme.

@alitaheri
Copy link
Member

All good 👍

@oliviertassinari
Copy link
Member

I'm no sure that this component is used by people 😁 cc @mbrookes.
@newoga All good 👍.

oliviertassinari added a commit that referenced this pull request Feb 5, 2016
[AppCanvas] Remove style-propable mixin
@oliviertassinari oliviertassinari merged commit 90588b9 into mui:master Feb 5, 2016
@alitaheri
Copy link
Member

I'm no sure that this component is used by people

Oh it is. I'm one of them 😆 😆

@oliviertassinari
Copy link
Member

Oh it is. I'm one of them

I used to use it too 😁.
Let's wait @newoga PR for the new AppBar approach.

@alitaheri
Copy link
Member

Yeah, I agree 😆

@newoga
Copy link
Contributor Author

newoga commented Feb 5, 2016

Let's wait @newoga PR for the new AppBar approach.

Haha, way to put some pressure on me 😆

@mbrookes
Copy link
Member

mbrookes commented Feb 5, 2016

Haha, way to put some pressure on me 😆

This isn't pressure enough?

https://github.com/callemall/material-ui/blob/master/ROADMAP.md#major-features

😆

@oliviertassinari
Copy link
Member

No pressure here. Stop working on the project by night 😴.

@newoga newoga deleted the #2852/app-canvas branch February 6, 2016 23:25
@zannager zannager added the package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants