[EnhancedSwitch] Remove window-listenable mixin #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
I'm loving this 😍 😍 👍 |
|
Yeah @oliviertassinari's component is making this really easy. 👍 |
| @@ -187,11 +183,6 @@ const EnhancedSwitch = React.createClass({ | |||
| window.removeEventListener('resize', this._handleResize); | |||
There was a problem hiding this comment.
Can we use the <EventListener /> for the resize event 😄?
There was a problem hiding this comment.
Thanks! Didn't realize this component was using the mixin and doing it manually!
oliviertassinari
added
PR: needs revision
newoga
force-pushed
the
#3305/enhanced-switch
branch
from
2bb64a8
to
b417dad
Compare
newoga
added
PR: Needs Review
and removed
PR: needs revision
|
I'm glad it's helping 😄. For the record, I needed it to listen for some cordova events: <EventListener elementName="document" onBackButton={this.handleBackButton} />@newoga Thanks! |
oliviertassinari
added a commit
that referenced
this pull request
Feb 12, 2016
[EnhancedSwitch] Remove window-listenable mixin
zannager
added
the
component: switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.