[TimePicker] Remove window-listenable mixin #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,4 @@ | |||
| import React from 'react'; | |||
| import WindowListenable from '../mixins/window-listenable'; | |||
There was a problem hiding this comment.
This one confused me a little. It looks like time-picker.jsx had the mixin but was referencing a function that wasn't defined on the class. I'm assuming that's the equivalent of a noop so I just removed the mixin without adding the EventListener
There was a problem hiding this comment.
possibly because someone removed the function but forgot to remove the mixin O.o
9 tasks
|
All good 👍 |
|
@newoga Thanks 👍. |
oliviertassinari
added a commit
that referenced
this pull request
Feb 12, 2016
[TimePicker] Remove window-listenable mixin
zannager
added
component: time picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.