Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReactNative] Add Subheader component #3346

Closed
wants to merge 1 commit into from
Closed

[ReactNative] Add Subheader component #3346

wants to merge 1 commit into from

Conversation

oliviertassinari
Copy link
Member

Continue exploring #593. That's more like a proof of concept.

I have:

  • Upgraded React Native from 0.17 to 0.19
  • Added react-native-webpack-server
  • Added the new component here: src/Subheader/Subheader.native.jsx
  • Implemented a simple version of the Subheader for React Native.

I wasn't able to make the Android build work, that seems to be an issue with the latest release (http://stackoverflow.com/questions/34969858/react-native-module-appregistry-is-not-a-registered-callable-module).

We have some challenges to solve:

  • How to we make sure we have the same API between the native and the browser?
  • How do we share the theme?

Result

iOS:
capture d ecran 2016-02-15 a 18 34 07
Browser:
capture d ecran 2016-02-15 a 18 34 24

@alitaheri
Copy link
Member

This is lovely 😍

@newoga
Copy link
Contributor

newoga commented Feb 15, 2016

Really cool! I'm not familiar with react-native development. Seems like there are a lot of files! 😨

How to we make sure we have the same API between the native and the browser?
How do we share the theme?

These are some interesting challenges.

I'm also curious how can we organize documentation in a way that's easy to differentiate between the two platforms.

@alitaheri
Copy link
Member

Are there possibly any transformer libraries that can take some browser code and give native code?

@oliviertassinari
Copy link
Member Author

I'm also curious how can we organize documentation in a way that's easy to differentiate between the two platforms.

Well, my plan is to build an application version of the documentation. Let's start simple.

Are there possibly any transformer libraries that can take some browser code and give native code?

The real challenge is around styling. I don't think that we can automate the transition from browser to native. Simply because less features are available with React Native. It's easier to convert some native code to the browser. For instance https://github.com/necolas/react-native-web.

@cgestes
Copy link
Contributor

cgestes commented Feb 15, 2016

I'am experimenting with react-native currently also. I'am willing to help.

Would it make sense to use flexbox for all our components?

@oliviertassinari
Copy link
Member Author

Would it make sense to use flexbox for all our components?

Yes, absolutely.

I'm experimenting with react-native currently also. I'm willing to help.

That would be awesome. Regarding the roadmap, the goal is to write an application version of the documentation. Once we have this, with all the examples, we are pretty much done 🎉.

  • It would be good to address [WIP] move components to directories #3212 before anythings.
  • We need to figure out how to use the muiTheme context to style the native components.
  • One of the first component to build is the LeftNav and the List so that we can navigate inside the documentation.
  • Then, we can implement the components we need. (In my case, it's half of the components)

@oliviertassinari oliviertassinari deleted the react-native-subheader branch February 16, 2016 10:01
@zannager zannager added the docs Improvements or additions to the documentation label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants