[LeftNav] Rename to Drawer #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `LeftNav` component to `Drawer` to better reflect the MD Spec and broader use cases than navigation. Also rename `openRight` propery to `openSecondary` to make RTL use less confusing. Update docs site examples to use the new component, and update wording. Rename docs site `AppLeftNav` to `AppNavDrawer`, and rename all internal functions. Closes #2697.
zannager
added
the
component: drawer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/ docs demo, and is linted.Rename
LeftNavcomponent toDrawerto better reflect the MD Specand broader use cases than navigation.
Also rename
openRightpropery toopenSecondaryto make RTL use less confusing.Update docs site examples to use the new component, and update wording.
Rename docs site
AppLeftNavtoAppNavDrawer, and rename all internal functions.Closes #2697.