-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release] v5.14.10 #39034
[release] v5.14.10 #39034
Conversation
mnajdova
commented
Sep 18, 2023
- I have followed (at least) the PR section of the contributing guide.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@mui/zero-tag-processor", | |||
"version": "0.0.1-alpha.3", | |||
"version": "0.0.1-alpha.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the versions of this package were bumped before so I did the same, but does it really make sense to bump them since they are still private? I think we should put them all back at 0.0.1-alpha.0 and keep them there until the first public release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 BTW this would be consistent with the workflow with pnpm - I omitted the private packages from lerna version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, we can address this separately 👍
Netlify deploy previewhttps://deploy-preview-39034--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versions look good.