Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][Menu] Focus last item after opening a menu using up arrow #40764

Merged
merged 3 commits into from
Jan 30, 2024
Merged

[base-ui][Menu] Focus last item after opening a menu using up arrow #40764

merged 3 commits into from
Jan 30, 2024

Conversation

Jaswanth-Sriram-Veturi
Copy link
Contributor

@Jaswanth-Sriram-Veturi Jaswanth-Sriram-Veturi commented Jan 23, 2024 •
edited
Loading

closes: #40596

@mui-bot
Copy link

mui-bot commented Jan 23, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-40764--material-ui.netlify.app/

@material-ui/unstyled: parsed: +0.28% , gzip: +0.17%
@mui/material-next: parsed: +0.13% , gzip: +0.11%
@mui/joy: parsed: +0.09% , gzip: +0.09%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against f72c01b

@zannager zannager added component: menu This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Jan 23, 2024
michaldudak
michaldudak reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks well! Just a small change in tests and we'll be able to merge it.

packages/mui-base/src/Dropdown/Dropdown.test.tsx Outdated Show resolved Hide resolved
michaldudak
michaldudak approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks a lot for making Base UI better!

@michaldudak michaldudak changed the title [base-ui][Menu] Fix: opening menu using up arrow now correctly focuses on last item instead of first item [base-ui][Menu] Focus last item after opening a menu using up arrow Jan 30, 2024
@michaldudak michaldudak merged commit 97f225c into mui:master Jan 30, 2024
19 checks passed
mostafa-rio pushed a commit to mostafa-rio/material-ui that referenced this pull request Feb 3, 2024
@Jaswanth-Sriram-Veturi @mostafa-rio
[base-ui][Menu] Focus last item after opening a menu using up arrow (m…
fb18105 
…ui#40764)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[base-ui][Menu] Incorrect up arrow key behavior
4 participants
@Jaswanth-Sriram-Veturi @mui-bot @michaldudak @zannager