Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Autocomplete] Display options provided to the options prop even if loading is true. #41677

Merged
merged 3 commits into from
Apr 4, 2024
Merged

[material-ui][Autocomplete] Display options provided to the options prop even if loading is true. #41677

merged 3 commits into from
Apr 4, 2024

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Mar 27, 2024 •
edited
Loading

Cherry-pick 31d5291 and d5c16c1.

@nekoya @ZeeshanTamboli
[material-ui][Autocomplete] Display options provided to the options…
9a66cdb 
… prop even if loading is true. (mui#41634)

Co-authored-by: ZeeshanTamboli <[email protected]>
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material component: autocomplete This is the name of the generic UI component, not the React module! regression A bug, but worse labels Mar 27, 2024
@mui-bot
Copy link

mui-bot commented Mar 27, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41677--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against de4db28

This was referenced Apr 2, 2024
Merged
Closed
Merged
@siriwatknp siriwatknp merged commit 42afab7 into mui:master Apr 4, 2024
19 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the cherry-pick/fix_autocomplete_loading branch April 10, 2024 06:31
This was referenced May 15, 2024
Open
Open
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
This was referenced Jun 5, 2024
Closed
Closed
@Crushoverride007 Crushoverride007 mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Open
Open
Open
@FaroukAmr FaroukAmr mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
@Poseidon-G Poseidon-G mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Closed
Closed
Closed
This was referenced Jun 6, 2024
Open
Open
@sufi0900 sufi0900 mentioned this pull request Jun 6, 2024
Open
This was referenced Jun 6, 2024
Open
Open
@mattboddy47 mattboddy47 mentioned this pull request Jun 6, 2024
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@mj12albert mj12albert Awaiting requested review from mj12albert

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeeshanTamboli @mui-bot @siriwatknp @nekoya