-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][examples] Improvements to Material UI UMD build removal #42284
[docs][examples] Improvements to Material UI UMD build removal #42284
Conversation
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the polish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, remove my approval, we shouldn't depend on me.
Oh damn! https://unpkg.com/browse/@mui/[email protected]/umd/ to compare with https://packagephobia.com/result?p=%40mui%2Fmaterial 10% smaller or 25% smaller, depending on how you look at this. We can use this to sell the change; no missed opportunities to do marketing 😄. |
Signed-off-by: Olivier Tassinari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ZeeshanTamboli
…2284) Signed-off-by: Olivier Tassinari <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
Following up for improvements reviewed in #42172 (review)
Preview example on my fork: https://raw.githack.com/ZeeshanTamboli/material-ui/improve-remove-umd-build-changes/examples/material-ui-via-cdn/index.html