[material-ui][Grid] Deprecate wrap prop
#42363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new transformer for Grid props where 'wrap' attribute is replaced with 'flexWrap'. The transformations apply to both the component usage and themes. This change also includes relevant test cases ensuring the accuracy and idempotency of the transformations.
A new section has been added to the migration document for the Grid component. The 'wrap' prop has now been deprecated in favor of MUI's 'flexWrap' system prop. This update also includes instructions for using a codemod to help with the migration as well as the corresponding update in the codemod README.
github-actions
bot
added
the
PR: out-of-date
# Conflicts: # docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md # packages/mui-codemod/README.md
github-actions
bot
removed
the
PR: out-of-date
DiegoAndai
reviewed
May 24, 2024
There was a problem hiding this comment.
Hey @fedirjh, thanks for working on this!
Here's my review. Overall, we should only deprecate and provide the codemod, we shouldn't change or remove any logic at this point.
packages/mui-codemod/src/deprecations/grid-props/grid-props.test.js
Outdated
Show resolved
Hide resolved
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
…grating-from-deprecated-apis.md Co-authored-by: Diego Andai <[email protected]> Signed-off-by: Fedi Rajhi <[email protected]>
…rid-wrap-deprecation-v6
Netlify deploy previewBundle size report |
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
DiegoAndai
added a commit
to DiegoAndai/material-ui
that referenced
this pull request
Aug 26, 2024
DiegoAndai
added a commit
that referenced
this pull request
Sep 6, 2024
Michael-Hutchinson
pushed a commit
to Michael-Hutchinson/material-ui
that referenced
this pull request
Sep 7, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41250
cc @DiegoAndai
Details
Deprecated
wrapin favor of the MUI systemflexWrapAdded grid-props section in the migration guide
Added grid-props codemod
I have followed (at least) the PR section of the contributing guide.