Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][Autocomplete] Fix spread key error in test #42775

Merged

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Jun 27, 2024

Fixes a React warning caused by key being spread. This only happens starting with React 18.3

image

@aarongarciah aarongarciah added test package: joy-ui Specific to @mui/joy needs cherry-pick The PR should be cherry-picked to master after merge React 19 support PRs required to support React 19 labels Jun 27, 2024
@aarongarciah aarongarciah mentioned this pull request Jun 27, 2024
15 tasks
@mui-bot
Copy link

mui-bot commented Jun 27, 2024

Netlify deploy preview

https://deploy-preview-42775--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fb71ebe

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the warning only triggered once? And that's why these have been showing up one by one? It would be great if we could have one PR for all of them 😅

@aarongarciah
Copy link
Member Author

@DiegoAndai this should be the last spread key warning in our tests. I double checked. Demos is another story (as we saw in the Autocomplete demos) because this is a runtime error that is triggered only when the piece of JSX runs. In the case of Autocomplete, most warnings were triggered when opening it.

@aarongarciah aarongarciah merged commit d204f41 into mui:next Jun 27, 2024
23 checks passed
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cherry-pick The PR should be cherry-picked to master after merge package: joy-ui Specific to @mui/joy React 19 support PRs required to support React 19 test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants