[codemod] Fix Divider props codemod #42919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
component: divider
Netlify deploy previewhttps://deploy-preview-42919--material-ui.netlify.app/ Bundle size report |
aarongarciah
commented
Jul 12, 2024
| key: 'opacity', | ||
| expression: j.literal('0.6'), | ||
| }); | ||
| if (!lightProp) { |
There was a problem hiding this comment.
Most of the changes above are because of the indentation change due to this early return.
There was a problem hiding this comment.
Check hide whitespace could help the review.
aarongarciah
commented
Jul 12, 2024
| const isLightPropTruthy = | ||
| !!lightProp.value?.expression.value || lightProp.value?.expression.value === undefined; | ||
|
|
||
| if (!isLightPropTruthy) { |
There was a problem hiding this comment.
If light={false} we already removed the prop so we don't continue with adding opacity to the sx prop.
sai6855
reviewed
Jul 12, 2024
packages/mui-codemod/src/deprecations/divider-props/test-cases/expected.js
Show resolved
Hide resolved
sai6855
approved these changes
Jul 12, 2024
|
@sai6855 the implementation is almost the same, just switched to early returns and added a check to do nothing in case |
sai6855
approved these changes
Jul 12, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
divider-propscodemod (introduced in #40947) removes thelightprop and addssx={{ opacity: 0.6 }}if noopacityis already passed to thesxprop.I noticed that the codemod adds the
opacityeven whenlight={false}, which seems wrong:The correct output should be:
This PR fixes the codemod and adds some tests cases to also cover the presence of
light: falsein theMuiDivider.defaultPropsof thethemeobject.@sai6855 let me know if my reasoning is correct.