[examples] Fix CDN live preview demo #43641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-43641--material-ui.netlify.app/ Bundle size report |
DiegoAndai
approved these changes
Sep 9, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://github.com/mui/material-ui/blob/master/examples/material-ui-via-cdn/README.md preview is broken.
Solution
See https://raw.githack.com/faq#diff-between-rawgithack-and-cdn for why this fixes the problem. Since it's only for demo purposes, we don't care about having our demo production ready.
Context
It's another follow-up on #42172. The problem got more visible with v6.x release. I noticed this trying some of the examples that we have (since it's a critical part of the user journey, wanted to experience it as a new user).
Since it was quick to fix, I skipped the opening an issue step and went to PR (It will be better to only open issues in the future, but they tend to be not solved, e.g. #42423 so this should be more effective, until we figure a way to make it work).