-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript] SystemCSSProperties
should not have SystemStyleObject
as value
#44029
[typescript] SystemCSSProperties
should not have SystemStyleObject
as value
#44029
Conversation
SystemCSSProperties
should not have SystemStyleObject
as value
Netlify deploy previewhttps://deploy-preview-44029--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
I have discovered that this change actually broke types in the sx props in some cases. For example, try to use I would be happy to open a PR to revert this, please let me know. |
I discovered this was actually an issue of types in our custom theme and was able to resolve |
It does not make sense for CSS Properties to have value as
SystemStyleObject
like this:This might be a slightly typescript per improvement and it won't have any affect on the consumer side because the
sx
prop currently support nesting object with any keys (due to CSS selector)