[code-infra] Fix icon builder tests #44143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
commented
Oct 17, 2024
| @@ -245,7 +245,7 @@ export async function handler(options) { | |||
| renameFilter = renameFilterModule.default; | |||
| } | |||
| if (typeof renameFilter !== 'function') { | |||
| throw Error('renameFilter must be a function'); | |||
There was a problem hiding this comment.
Also, eslint is not running on this file
Netlify deploy previewhttps://deploy-preview-44143--material-ui.netlify.app/ Bundle size report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying to figure out why I have a failing test locally in vitest that doesn't seem to break in mocha. The following produces a failing test:
But when you try running the global command:
No test is running. Somewhere along the way we started running the build script natively in node. The file was renamed to .mjs. The test runner only looks for .js, .ts, and .tsx. The author didn't see any tests break after running them and assumed they were good.
We can steal the pattern from mui/mui-x#14508 to make sure all tests are included. looks like the icons builder tests were the only ones with the problem.
before:
after: