[DataGridPremium] Fix aggregated column resizing #10079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
bug 🐛
Netlify deploy previewNetlify deploy preview: https://deploy-preview-10079--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
cherniavskii
commented
Sep 1, 2023
| @@ -232,17 +233,30 @@ export function useGridColumns( | |||
| (field, width) => { | |||
| logger.debug(`Updating column ${field} width to ${width}`); | |||
|
|
|||
| const column = apiRef.current.getColumn(field); | |||
| const newColumn = { ...column, width }; | |||
| apiRef.current.updateColumns([newColumn]); | |||
There was a problem hiding this comment.
It doesn't make much sense to call updateColumns to resize them, so I updated the implementation to calculate the new columns' width and update the state.
romgrk
reviewed
Sep 5, 2023
packages/grid/x-data-grid-pro/src/hooks/features/columnResize/useGridColumnResize.tsx
Show resolved
Hide resolved
romgrk
reviewed
Sep 5, 2023
packages/grid/x-data-grid/src/hooks/features/columns/useGridColumns.tsx
Outdated
Show resolved
Hide resolved
romgrk
approved these changes
Sep 5, 2023
MBilalShafi
reviewed
Sep 5, 2023
| @@ -0,0 +1,55 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
Off topic to this PR:
It could certainly be better to also move/resize the aggregation footer item with the resize (which happens on mouseout right now)
There was a problem hiding this comment.
Yes, it's in a separate PR #10229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10078
Before: https://codesandbox.io/s/sleepy-tom-dfqv28
After: https://codesandbox.io/s/elated-elgamal-wjzw9j
TODO: