Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Remove the deprecated methods and formats from the adapters #10776

Merged
merged 23 commits into from
Nov 13, 2023
Merged

[pickers] Remove the deprecated methods and formats from the adapters #10776

merged 23 commits into from
Nov 13, 2023

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Oct 23, 2023 •
edited
Loading

Closes #10774
Closes #10775

Waiting for #10990

@flaviendelangle flaviendelangle self-assigned this Oct 23, 2023
@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x labels Oct 23, 2023
@mui-bot
Copy link

mui-bot commented Oct 23, 2023 •
edited
Loading

Deploy preview: https://deploy-preview-10776--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 2f21f3a

LukasTy
LukasTy approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just remind about an idea you had that might be more relevant after these changes. 😉
#6717 (comment)

packages/x-date-pickers/src/PickersCalendarHeader/PickersCalendarHeader.tsx Outdated Show resolved Hide resolved
@flaviendelangle flaviendelangle changed the base branch from master to next November 6, 2023 14:04
@k725
Copy link
Contributor

k725 commented Nov 9, 2023 •
edited
Loading

@LukasTy @flaviendelangle

Hi. This PR seems to remove #10774 (e.g. monthAndYear), is there an alternative? I don't live in a mm/yyyy culture. If there is an appropriate discussion page/Issue, please let me know.

@flaviendelangle
Copy link
Member Author

flaviendelangle commented Nov 9, 2023 •
edited
Loading

@k725 hi, could you describe which part of the UI you are trying to update using monthAndYear?

@k725
Copy link
Contributor

k725 commented Nov 9, 2023 •
edited
Loading

@flaviendelangle

I use monthAndYear prop to change the format of the year and month in the upper left corner of <DateCalendar />.
Simply put, these two links.

#4463
https://stackoverflow.com/questions/76421645

@flaviendelangle
Copy link
Member Author

Our plan is to add a new prop on the header during the alpha to let you override the format used for this part of the UI 👍
We will have it by the end of the alpha so that you can safely upgrade

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 10, 2023
@flaviendelangle flaviendelangle mentioned this pull request Nov 10, 2023
Merged
3 tasks
@flaviendelangle
Copy link
Member Author

Since we have a user asking for the new prop, I'll wait for it to be available before merging this PR.
You can have a look at #10990 for the new prop. It is now properly documented as well.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 10, 2023
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 10, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 10, 2023
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 10, 2023
flaviendelangle
flaviendelangle commented Nov 10, 2023
View reviewed changes
docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
@@ -104,6 +104,213 @@ adapter.isValid(dayjs('2022-04-17T15:30'));
If you are just passing an adapter to `LocalizationProvider`, then you can safely skip this section.
:::

### Remove the `getDiff` method
Copy link
Member Author

@flaviendelangle flaviendelangle Nov 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been a lot more exhaustive than needed and I hope nobody will complain about the removal of these methods 😆

@flaviendelangle flaviendelangle merged commit 0934ebd into mui:next Nov 13, 2023
18 checks passed
@flaviendelangle flaviendelangle deleted the deprecated-adapters branch November 13, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x
Projects
None yet
Milestone
No milestone
4 participants
@flaviendelangle @mui-bot @k725 @LukasTy