Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove dead prop #11214

Closed

Conversation

oliviertassinari
Copy link
Member

I noticed this in #207 (comment), it doesn't seem to do anything anymore.

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! labels Nov 27, 2023
@oliviertassinari oliviertassinari marked this pull request as ready for review November 27, 2023 17:43
@mui-bot
Copy link

mui-bot commented Nov 27, 2023

Deploy preview: https://deploy-preview-11214--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d3c725e

@romgrk
Copy link
Contributor

romgrk commented Nov 27, 2023

The prop seems to be passed in useGridVirtualScroller.tsx. If it's removed from there, it's going to end up in the ...other variable destructured a few lines later. Also if we can avoid touching that area I'd prefer it, it might cause conflicts with the sticky PR that is nearly complete.

romgrk added a commit to romgrk/mui-x that referenced this pull request Nov 27, 2023
@romgrk
Copy link
Contributor

romgrk commented Nov 27, 2023

Nevermind, got confused between cell & row. This makes sense, it's not used. I've picked up on the sticky PR as well to avoid conflicts. Our GridCell type extends { [x: string]: any } so we don't get warnings for this, we should clean up that type.

@oliviertassinari oliviertassinari added the on hold There is a blocker, we need to wait label Nov 27, 2023
@oliviertassinari oliviertassinari mentioned this pull request Nov 27, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes on hold There is a blocker, we need to wait
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants