Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Use describeTreeView for items test (partial) #12893

Merged
merged 9 commits into from
May 17, 2024
Merged

[core] Use describeTreeView for items test (partial) #12893

merged 9 commits into from
May 17, 2024

Conversation

flaviendelangle
Copy link
Member

Part of #12433

@flaviendelangle flaviendelangle self-assigned this Apr 24, 2024
@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Apr 24, 2024
@mui-bot
Copy link

mui-bot commented Apr 24, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12893--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 25b0c4f

@flaviendelangle flaviendelangle marked this pull request as ready for review April 24, 2024 11:07
@flaviendelangle flaviendelangle mentioned this pull request Apr 24, 2024
Closed
12 tasks
noraleonte
noraleonte approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Left a very tiny nitpick 🙈

packages/x-tree-view/src/internals/plugins/useTreeViewItems/useTreeViewItems.test.tsx Outdated Show resolved Hide resolved
@flaviendelangle @noraleonte
Update packages/x-tree-view/src/internals/plugins/useTreeViewItems/us…
db4ae46 
…eTreeViewItems.test.tsx

Co-authored-by: Nora <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
LukasTy
LukasTy approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, great job! 👏

test/utils/tree-view/describeTreeView/describeTreeView.types.ts Outdated Show resolved Hide resolved
packages/x-tree-view/src/internals/plugins/useTreeViewItems/useTreeViewItems.test.tsx Outdated Show resolved Hide resolved
packages/x-tree-view/src/internals/plugins/useTreeViewItems/useTreeViewItems.test.tsx Outdated Show resolved Hide resolved
packages/x-tree-view/src/internals/plugins/useTreeViewItems/useTreeViewItems.test.tsx Outdated Show resolved Hide resolved
@flaviendelangle flaviendelangle merged commit 760ea7e into mui:master May 17, 2024
15 checks passed
@flaviendelangle flaviendelangle deleted the tree-items-describeTreeView branch May 17, 2024 10:51
arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request May 23, 2024
@flaviendelangle @noraleonte @LukasTy
[core] Use describeTreeView for items test (partial) (mui#12893)
6f62a77 
Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Nora <[email protected]>
Co-authored-by: Lukas <[email protected]>
@Rossen27 Rossen27 mentioned this pull request Jun 22, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@flaviendelangle @noraleonte
@LukasTy @DungTiger
[core] Use describeTreeView for items test (partial) (mui#12893)
a155d4e 
Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Nora <[email protected]>
Co-authored-by: Lukas <[email protected]>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@flaviendelangle @noraleonte
@LukasTy @thomasmoon
[core] Use describeTreeView for items test (partial) (mui#12893)
8a96593 
Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Nora <[email protected]>
Co-authored-by: Lukas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@noraleonte noraleonte noraleonte approved these changes

@michelengelen michelengelen Awaiting requested review from michelengelen

Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaviendelangle @mui-bot @LukasTy @noraleonte