-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Fix: column group change bug #12965
Conversation
Deploy preview: https://deploy-preview-12965--material-ui-x.netlify.app/ |
@romgrk Is it ok to review this one or do you want to check the failing tests first? |
It's ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't reproduce the issue anymore 👍
Apart from one minor suggestion that I added, it LGTM.
Thanks for fixing it, I think I experienced the same issue when working on pivoting 👍🏻 |
fixed by mui#12965
Closes #12885
Before: https://codesandbox.io/p/sandbox/blissful-thompson-tq5g2m
After: https://codesandbox.io/p/sandbox/brave-cookies-2dzcvk