Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Add JSDoc to every instance method #13219

Merged
merged 5 commits into from
May 23, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented May 23, 2024

I was supposed to do it for some time 👼

@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label May 23, 2024
@flaviendelangle flaviendelangle self-assigned this May 23, 2024
@mui-bot
Copy link

mui-bot commented May 23, 2024

Deploy preview: https://deploy-preview-13219--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 74460fb

@flaviendelangle flaviendelangle marked this pull request as ready for review May 23, 2024 12:45
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 🎉
Left some nitpicks, but otherwise LGTM 😄

flaviendelangle and others added 2 commits May 23, 2024 17:38
…n/useTreeViewExpansion.types.ts

Co-authored-by: Nora <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
…eTreeViewItems.types.ts

Co-authored-by: Nora <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
@flaviendelangle flaviendelangle merged commit 1a453ab into mui:master May 23, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the document-private-api branch May 23, 2024 17:08
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants