[core] Add comment on why logic to sync column header #13248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
core
| const fieldsString = colCellEl.getAttribute('data-fields'); | ||
| return fieldsString?.startsWith('|-') ? fieldsString!.slice(2, -2).split('-|-') : []; | ||
| return colCellEl.getAttribute('data-fields')!.slice(2, -2).split('-|-'); |
There was a problem hiding this comment.
I imagine we don't need defensive logic here
romgrk
approved these changes
May 25, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my due diligence on https://app.ashbyhq.com/jobs/c86e52ce-0f3b-41cd-871b-5a7fd4044238/candidate-pipeline/active/right-side/candidates/9f3a6ab2-c71b-4b25-a92b-3996f1d04647/applications/ed537f84-6d1b-4efc-b788-a29fa6c7a081/emails. I looked at #12863. I wanted to better understand how the changes connect to the rest of the codebase.
I have added comments to explain why this much complexity.
It would be possible to cheat this, meaning working around https://codesandbox.io/p/sandbox/style-sync-np6fdh?file=%2Fsrc%2FApp.js%3A5%2C30, but it would mean adding some randomness to the width, hacky 😄