[test] Add tests for the custom slots of TreeItem2
#13314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
test
core
|
Deploy preview: https://deploy-preview-13314--material-ui-x.netlify.app/ |
flaviendelangle
commented
May 31, 2024
| skip: ['reactTestRenderer', 'componentProp', 'componentsProp', 'themeVariants'], | ||
| })); | ||
|
|
||
| describeSlotsConformance({ |
There was a problem hiding this comment.
This works great for super basic slots that are always rendered, but describeSlotsConformance will need a lot more work to support more complex slots like dragAndDropOverlay or components like DatePicker.
But it's a 1st draft and for now I think it does the job.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
noraleonte
approved these changes
Jun 12, 2024
This was referenced Jul 12, 2024
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12434