Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Move useTreeViewId to the core plugins #13566

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jun 20, 2024

🥳 the core plugins are now stable enough to be used with plugins that have props and/or instance methods.

IMHO the end goal is that any plugin used in useTreeItem2 (and the utility hooks it uses) is either optional or a core plugin, so that someone creating a headless Tree View can pass 0 plugin and still have a component that works.

@mui-bot
Copy link

mui-bot commented Jun 20, 2024

Deploy preview: https://deploy-preview-13566--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against db8f506

@flaviendelangle flaviendelangle marked this pull request as ready for review June 20, 2024 12:47
@flaviendelangle flaviendelangle self-assigned this Jun 20, 2024
@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Jun 20, 2024
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement 🥳 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants